search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

table.js: use `\n` instead of EOL. #127

Closed XhmikosR closed 8 years ago

XhmikosR commented 8 years ago

Before: before

After: after

I was getting a CR which is \r after each asset. Every other line is LF (\n) even on Windows. Not sure what happens on OSX.

soulgalore commented 8 years ago

hey @XhmikosR thanks, I'll test it tonight but it should work. Great :)

XhmikosR commented 8 years ago

@soulgalore: I tried to find what is using LF hardcoded, and it seems it's cli-table2. word-wrap has an option for newlines, but the result is the same since cli-table2 is always using LF on Windows.

So, this seems like a quick fix as long as we don't break OSX.

soulgalore commented 8 years ago

thanks @XhmikosR !