Closed simonc closed 8 years ago
Please review the guidelines for contributing to this repository.
npm test
npm run lint
This PR fixes the labelOnInput by treating the following points that were making broken and unhelpful:
textarea
select
for
undefined
entry.attributes.for.value
offending
id
name
thank you @simonc !!!
My pleasure ☺️
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
npm test
and test linting bynpm run lint
Description
This PR fixes the labelOnInput by treating the following points that were making broken and unhelpful:
textarea
andselect
for
attributes always returnsundefined
it should beentry.attributes.for.value
offending
array is not filled with theid
orname
of the offending inputs