Add CLI option to control viewport size

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.

MIT License

1.21k stars 64 forks source link

Closed jsocol closed 7 years ago

jsocol commented 7 years ago

For responsive sites it's important to be able to be deterministic about viewport size. I'd approach this by making two small changes:

Add a --viewPort option in lib/cli.js that took a WIDTHxHEIGHT argument.
Update the --mobile option to not overwrite the --viewPort value if it was set by the user.

If this sounds good I'm happy to open a PR!

soulgalore commented 7 years ago

Hey @jsocol yes that sounds great, we haven't done that yet, a PR would be super thanks!

jsocol commented 7 years ago

@soulgalore Opened #209, thanks!