search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Add the ability to sort the adviceInfo table #222

Closed lapa182 closed 7 years ago

lapa182 commented 7 years ago

I think we should be able to sort the advices just like the files in the tablet list, this can make the developer life easier to prioritise the fixes/enchantments.

soulgalore commented 7 years ago

hey @lapa182 yes sorting by highest or lowest score should be best right? Now it's sorted by name of the advice, I think we should keep that and add the possibility to sort by score. Do you have time to do a PR?

lapa182 commented 7 years ago

Sure, @soulgalore, I don't know if supposed to be that way but I'm going to open the PR with the change.

lapa182 commented 7 years ago

PR was raised :)

tobli commented 7 years ago

Thanks for the reminder, I'll have a look.

lapa182 commented 7 years ago

This was merged in https://github.com/sitespeedio/coach/pull/223