search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Browser identification doesn't work with mobile emulation. #250

Closed tobli closed 5 years ago

tobli commented 7 years ago

Since browser identification depends on window.navigator.userAgent, a 'mobile' override will not match 'Firefox' or 'Chrome'. Maybe we should change how it's reported in the results table to something like 'Chrome (emulated mobile)'

bin/webcoach.js --mobile --screenshot http://www.dn.se

│               The coach: Clear Eyes. Full Hearts. Can’t Lose. Version 0.32.0               │
├────────────────────────────────────────────────────────────────────────────────────────────┤
│                                     http://www.dn.se/                                      │
├────────────────────────────────────────────────────────────────────────────────────────────┤
│                                          unknown                                           │
├────────────────────────────────────────────────────────────────────────────────────────────┤
│                                        INFORMATION                                         │
soulgalore commented 5 years ago

I partly fixed this so we at least say Chrome (emulated mobile) but the data from Browsertime is still undefined. We could make a follow up fix there.