search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Scoring for files that are outside of site control #265

Open jaydub2099 opened 7 years ago

jaydub2099 commented 7 years ago

I was wondering if there is a way to exclude certain requests from some of the scoring for Coach. For example we have some Coach results that are for files that we do not control and thus cannot ever improve our score in those performance categories.

For example:

cacheHeaders The page has 3 request(s) that are missing a cache time. Configure a cache time so the browser doesn't need to download them every time. It will save 1.7 kB the next access.

The 3 files listed are for 3rd party files.

Same issues for scores in these sections:

cacheHeadersLong privateAssets

We are using coach via sitespeed.io if that matters. Just wondering if there is a way to flag certain files or domains to exclude from scoring.

soulgalore commented 7 years ago

Hi @jaydub2099 yes it is by design from an end user perspective.

In older versions I think we had a couple of "known" offenders that were skipped when we did the score (=Google Analytics), but I never felt that it was good.

The way I used this before was to have those 3rd party assets as leverage to the product manager like we can do this much but still miss out as long as we use X. But I know, it not always possible to get rid of them. @tobli @beenanner what's your take on this?

Best Peter

beenanner commented 6 years ago

@soulgalore / @tobli what about categorizing them like we did in pagexray (i.e. 1st vs 3rd party) via a regex?

soulgalore commented 6 years ago

@beenanner yes that could be a way to fix it!

shaqb commented 4 years ago

Hey guys. Just wondered if you thought about bumping up the priority on this one as we're also getting marked down for some third parties out of our control. Makes it hard for our devs to judge whether they've made an impact or not.

soulgalore commented 4 years ago

I see your point but I still think you as a site owner are responsible for third parties, so its low prio for me, sorry. You can choose what third party tools to use.