Update google-chrome for Browsertime 3.0

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.

MIT License

1.21k stars 64 forks source link

Update google-chrome for Browsertime 3.0 #290

Closed sodabrew closed 6 years ago

sodabrew commented 6 years ago

Since Browsertime 3.0, use google-chrome instead of google-chrome-beta.

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

[ ] Check that your change/fix has corresponding unit tests
[ ] Verify that the test works by running npm test and test linting by npm run lint
[ ] Squash commits so it looks sane

Description

Please describe your pull request and tell us the fix #

Thank you for helping the coach!

sodabrew commented 6 years ago

docker run sitespeedio/coach https://sitespeed.io
/start.sh: line 4: google-chrome-beta: command not found

after:

docker run (local-build-sha) https://sitespeed.io
Google Chrome 66.0.3359.139
Mozilla Firefox 61.0
Error running advice:  Error: ENOENT: no such file or directory, open '/usr/src/app/dist/coach.min.js'

... on to the next problem!

soulgalore commented 6 years ago

Ah thanks @sodabrew let me fix that other problem, give me a couple of minutes ...

soulgalore commented 6 years ago

For the other problem @sodabrew you need to build the coach before you pack the Docker container. That should automatically happen if you use the latest version 2.0.3 up on the Docker hub in 5 minutes or so. Thanks again for the fix!

sodabrew commented 6 years ago

Oh, I see the README :)

I'll work on a Dockerfile with a build step.