Closed sodabrew closed 6 years ago
docker run sitespeedio/coach https://sitespeed.io
/start.sh: line 4: google-chrome-beta: command not found
after:
docker run (local-build-sha) https://sitespeed.io
Google Chrome 66.0.3359.139
Mozilla Firefox 61.0
Error running advice: Error: ENOENT: no such file or directory, open '/usr/src/app/dist/coach.min.js'
... on to the next problem!
Ah thanks @sodabrew let me fix that other problem, give me a couple of minutes ...
For the other problem @sodabrew you need to build the coach before you pack the Docker container. That should automatically happen if you use the latest version 2.0.3 up on the Docker hub in 5 minutes or so. Thanks again for the fix!
Oh, I see the README :)
I'll work on a Dockerfile with a build step.
Since Browsertime 3.0, use google-chrome instead of google-chrome-beta.
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
npm test
and test linting bynpm run lint
Description
Please describe your pull request and tell us the fix #
Thank you for helping the coach!