sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

[mimeTypes] False positive for OGG MIME type #302

Closed znerd closed 4 years ago

znerd commented 5 years ago

Currently [mimeTypes] complains about an .ogg file having an incorrect MIME type when it is audio/ogg.

However, according to these documents, that MIME type is correct:

Sample:

Context:

soulgalore commented 5 years ago

Hi @znerd thanks for creating the issue! I think the problem comes from PageXray, it's there each response is categorized: https://github.com/sitespeedio/pagexray/blob/master/lib/util.js#L6-L21

Any change you can do a PR and update it? Thanks Peter

soulgalore commented 5 years ago

Hmm that advice seems to not be so correct since it relays on things specified in PageXray. Let me fix that later on and for now update page xray.

znerd commented 5 years ago

Any change you can do a PR and update it?

While I started looking into it I noticed you beat me to it – thanks 👍

I guess all that's remaining here is that the dependency version is bumped, and then a new Coach release?

soulgalore commented 5 years ago

I had time to fix that yesterday so it went out with 2.3.0. New sitespeed.io will be released on Wednesday.

sumeetrohra commented 4 years ago

@soulgalore this issue is fixed.

soulgalore commented 4 years ago

Thanks @sumeetrohra for noticing!