search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Favicon coach score #312

Closed SowmyaMastaiah closed 5 years ago

SowmyaMastaiah commented 5 years ago

When executing sitespeed coach under performance advice -- "favicon" always has score "0" even though favicons are present on page. I tried to execute on many other URL's and faced same issue.

soulgalore commented 5 years ago

Hi @SowmyaMastaiah thanks for reporting, can you show me a URL and how you run? I think if I remember correctly it should work in Chrome but it could be that Firefox misses the favicon. If you can provide an example I can have a look.

Thanks Peter

SowmyaMastaiah commented 5 years ago

Hi Peter,

docker run sitespeedio/coach:2.0.6 https://www.zoro.com -f json I have tried different URLS like nytimes,cnn and also tried sample site provided by sitespeed.io all had same issue.

http://antistatique.github.io/performance-metrics/sitespeed-result/letemps.ch/2016-05-26-10-59-50/pages/www_letemps_ch-theme-sante.html

URL - http://www.letemps.ch/theme/sante

Thanks, Sowmya

soulgalore commented 5 years ago

This was a bug in the current version, I've fixed it for the coming 3.0.

SowmyaMastaiah commented 5 years ago

Thank you!!

soulgalore commented 5 years ago

Closing this for 3.0