search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

Error getting HAR from FF #32

Closed soulgalore closed 8 years ago

soulgalore commented 8 years ago

http://sj.se

[2016-02-28 14:56:30] Error from Firefox HAR generation: {"message":"JSON.parse is not a function","stackTrace":[{"methodName":"anonymous/triggerExport/<","fileName":"http://www.sj.se/ line 69 > Function","lineNumber":7,"columnNumber":29}]}
Error running advice:  { message: 'JSON.parse is not a function',
  stackTrace: 
   [ { methodName: 'anonymous/triggerExport/<',
       fileName: 'http://www.sj.se/ line 69 > Function',
       lineNumber: 7,
       columnNumber: 29 } ] }
tobli commented 8 years ago

I can't reproduce this when running (with Firefox 46):

webcoach http://www.sj.se

I guess the code, browser and site have all changed since February… Hopefully this error is no more, so closing.

soulgalore commented 8 years ago

Yep it was the old version of the site. They used to override JSON, but we handle that nowadays (I think).

tobli commented 8 years ago

Right, would be useful to have as a test case if we could find something similar and extract it.