search

sitespeedio / coach

Clear Eyes. Full Hearts. Can’t Lose.
MIT License
1.21k stars 64 forks source link

This should be 3rd person present tense #98

Closed rickycodes closed 8 years ago

rickycodes commented 8 years ago

Just a simple word change

rickycodes commented 8 years ago

There's a failing test, but it has nothing to do with my change :(

Currently failing on travis:

1) Accessibility browser:chrome "before all" hook:
     Error: timeout of 60000ms exceeded. Ensure the done() callback is being called in this test.

This also fails for me (locally):

1) info - h2 browser:firefox Should be able to know if the connection is H2:

      AssertionError: false === true
      + expected - actual

      -false
      +true

      at test/dom/info/h2Test.js:22:20
      at tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (node_modules/bluebird/js/release/promise.js:502:31)
      at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:559:18)
      at Promise._settlePromise0 (node_modules/bluebird/js/release/promise.js:604:10)
      at Promise._settlePromises (node_modules/bluebird/js/release/promise.js:683:18)
      at Async._drainQueue (node_modules/bluebird/js/release/async.js:138:16)
      at Async._drainQueues (node_modules/bluebird/js/release/async.js:148:10)
      at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/release/async.js:17:14)
soulgalore commented 8 years ago

yep Travis has hickups sometimes and needs a re-push.

soulgalore commented 8 years ago

thanks @rickycodes for the PR :)