search

sitespeedio / jenkins.sitespeed.io

A Jenkins plugin for sitespeed.io
Apache License 2.0
31 stars 3 forks source link

Would like the option to set AVERAGE_LIMIT for sitespeed.io-junit #5

Closed dominicmcginnis closed 10 years ago

dominicmcginnis commented 10 years ago

I want to be able to override the AVERAGE_LIMIT setting for sitespeed.io-junit, however, both the useragent and AVERAGE_LIMIT use the same flag "-a". I recommend altering the flag for sitespeed.io to "-ua".

soulgalore commented 10 years ago

Hi @dominicmcginnis ah maybe that isn't clear, you have two different input fields in Jenkins: one called Sitespeed.io configuration and one JUnit configuration, so you put only parameters relevant to the JUnit script (http://www.sitespeed.io/documentation/#junit) in the second one. Or have you seen them collide?

dominicmcginnis commented 10 years ago

@sitespeedio We can close this. I misread that and wasn't thinking that the 2nd field was for sitespeed.io-junit configs....

Thanks,

soulgalore commented 10 years ago

np