search

sitetent / tentcss

:herb: A CSS survival kit. Includes only the essentials to make camp.
http://css.sitetent.com/
MIT License
406 stars 31 forks source link

Math in breakpoint-max mixin no longer working in newer version of Sass #29

Open jmcgaha opened 6 years ago

jmcgaha commented 6 years ago

After recently upgrading to gulp-sass 3.2.1 which uses node-sass 4.8.3, the math to subtract 1px no longer works leaving me things like:

max-width(48em - 0.0625em) in the processed CSS which does not work in the browser.

As a workaround I had to remove the px to em conversion for that 1px and for each breakpoint size. Could be related to https://github.com/sitetent/tentcss/issues/28, but I tried some of the suggested methods and it still wasn't working.

https://github.com/sitetent/tentcss/blob/bac3d003a7c45a5b8be59bef50328e50bd99256c/src/02_tools/_breakpoints.scss#L20

ulinaaron commented 6 years ago

Thanks @jmcgaha! I'll take a look at this and see if I can get a refactor for the current version of Tent.