sitexw / FuckAdBlock

Detects ad blockers (AdBlock, ...)
fuckadblock.sitexw.fr
MIT License
1.9k stars 255 forks source link

Naming (profanity) #17

Closed stevecoug closed 9 years ago

stevecoug commented 9 years ago

I'd like to use this on my production site, but having profanity in the name makes it something I can't justify putting in our production code. Would you consider renaming it in the future?

sitexw commented 9 years ago

"Unfortunately", the popularity of the script comes in part (I think) of his name. It would be a shame to change, especially as he begins to become popular.

It bothers you that much to have that name in your Script? The end user will never see it and for people who watch the code, it will add a touch of humor.

What is it that bothers you? The file name? The name of the variable?

stevecoug commented 9 years ago

Let's just say that the users of my site wouldn't find it so humorous.

sitexw commented 9 years ago

The only thing I can advise you to do, is a Fork of the project and then change the filename and variables.

SubJunk commented 9 years ago

@stevecoug I would be happy to make the modifications for you if you want since I sympathize with your position

stevecoug commented 9 years ago

I just wrote a script that downloads the latest .js file and runs it through sed to modify it

SubJunk commented 9 years ago

:+1:

sitexw commented 9 years ago

I just created a second version of FuckAdBlock project, BlockAdBlock. This fork is always updated together FuckAdBlock.

stevecoug commented 9 years ago

Thank you, I appreciate it.

sitexw commented 9 years ago

No problem.