Detecting Adblock when there adblock is disabled?

sitexw / FuckAdBlock

Detects ad blockers (AdBlock, ...)

fuckadblock.sitexw.fr

MIT License

1.89k stars 257 forks source link

Detecting Adblock when there adblock is disabled? #59

Closed KyogoBlog closed 7 years ago

KyogoBlog commented 7 years ago

https://kyogo.me/adblock

I copy and pasted the code. I don't know why it keeps saying adblock is detected when it is not.

sitexw commented 7 years ago

For me, it works. You use what exactly blocker?

pyper commented 7 years ago

I have seen something similar before. What happens is some CSS framework, or JS Framework, graphic change to make the page load pretty, etc. Sets the body elements to display none or visibility hidden for a fraction of a second, thus causing a false positive. It then removes the CSS as the page continues to load. The funny thing it is more pronounced when the browser is fast. For example, Safari is very fast and may get the problem there, but not in FF or Chrome. Anyhow do this to test it:

1) Open up a console. It slows down the page load enough that you can verify it is a problem caused by a temporary CSS state.

2) Put in a event to test for a false positive as soon as you can. So first chance you can manipulate the DOM grab any child of body and see if it has display none or visibility hidden and output a alert or console.log indicating so. It will likely catch it fast enough to tell you that was the issue.

KyogoBlog commented 7 years ago

So I think it is beta v4 that is not working! I use the regular adblock. https://getadblock.com/

Beta v4: https://kyogo.me/adblockv4

Original: https://kyogo.me/adblock

sitexw commented 7 years ago

In this case, I think this is normal because the file "fuckadblock.min.js" does not exist :

KyogoBlog commented 7 years ago

Fixed it. Now I will try to work out the integrity for maximum secrurity

sitexw commented 7 years ago

Great ! Yes, I advise you very strongly integrity system, it can secure better detection.

KyogoBlog commented 7 years ago

Do I need to change the SHA code for my website or do I keep it the same?

sitexw commented 7 years ago

As long as the file does not change one character, you have to keep the same SHA. The server or name web site, has no impact on the SHA. But if by chance, you want to compress the file (mimify) that would remake the SHA on this site : https://www.srihash.org/

KyogoBlog commented 7 years ago

Got this error with the maximum security.

sitexw commented 7 years ago

This one works for me (for fuckadblock.min.js 4.0.0-beta.3) :

integrity="sha384-oiO90JrGr6v49XI21iWwrxl1QY51C48/8D/qofKneFlKcV64YuSuug2GdqrdefBo"

KyogoBlog commented 7 years ago

You are awesome! It works ! Thanks so much 👍