sitexw / FuckAdBlock

Detects ad blockers (AdBlock, ...)
fuckadblock.sitexw.fr
MIT License
1.89k stars 257 forks source link

False positives due to tracking protection #60

Closed e7o-de closed 7 years ago

e7o-de commented 7 years ago

Having issues with a site using your "nice" script. Getting a bunch of error messages in Firefox' console saying:

The resource at "..." was blocked because tracking protection is enabled.

Obviosly, your script is not blocked, because the page is complaining about an (imaginary) adblocker. Now, the direct question: Do I have to install an Adblocker to protect me from your crazy script, if it even complains on a Firefox without any extensions installed?

(Btw, I can understand the purpose of not having ads blocked on a page, but providing scripts blocking a built-in tracking protection is not acceptable in any way in a post-Snowden age.)

sitexw commented 7 years ago

Hello, I understand your displeasure.

Think you can send me (in private if you want) the URL of the page or site that is the problem? This will allow me to determine if this is a problem in the script or a problem using the webmaster.

Thank you.

e7o-de commented 7 years ago

One page where I noticed it is http://uploaded.net/file/x8ww1rhl

sitexw commented 7 years ago

For my part, everything works on Firefox (I do not have AdBlock installed). image No Javascript errors concerns the file "ablock.js" (which contains FuckAdBlock).

e7o-de commented 7 years ago

No, your adblock script is included, that's the problem. It gets loaded, but doesn't check for an adblocker, it just checks if the other scripts from some random tracking networks were loaded. To only block adblock, there would be a check required which actually checks for elements with same origin being filtered, or you should call it "FuckPrivacy" or so.

Actually, not sure why Firefox enabes Tracking Protection just for some users. privacy.trackingprotection.enabled is still false on my Firefox installation and I'm not in private mode (just don't saving any history), must be a different setting which I cannot find right now.