False positive on some Chrome Browsers

sitexw / FuckAdBlock

Detects ad blockers (AdBlock, ...)

fuckadblock.sitexw.fr

MIT License

1.9k stars 255 forks source link

False positive on some Chrome Browsers #66

Closed rmadisonhaynie closed 7 years ago

rmadisonhaynie commented 7 years ago

I am having some users receiving false positives in Chrome. I've debugged on one of their machines and I can see that the bait div is being added to the DOM but the offsetHeight and clientHeight are 0 causing the detection to be true.

Any ideas here?

rmadisonhaynie commented 7 years ago

The issue was a combo of zoom level and maybe some other factors (I say this since users experienced same issue but with different zoom levels, including 100%).

Work around was to zoom in.

Fix is to set bait style height and width to something larger.

Could not reproduce on FF or IE