search

sitmun / sitmun-admin-app

Administration application for the SITMUN system.
European Union Public License 1.2
0 stars 0 forks source link

TERRITORY - bounding box decimals #34

Closed montsemarco closed 3 years ago

montsemarco commented 3 years ago

Decimals are not allowed in BBOX. If someone decides to use geographic coordinates this is a must.

By the way, it would be useful to record the coordinate system that we are using in the 'generic' table (the table that contains the default administrator language)

fjlopez commented 3 years ago

@lucenasj BBOX can be provided by the API as a data structure rather as a string (e.g. minx, miny, maxx, maxy of reals). This could help to fix this issue.

@montsemarco I agree with your proposal for the SRS. I think that such SRS should be the SRS of the BBOX, isn't?

montsemarco commented 3 years ago

@lucenasj It would be ok, if the others participants agree, of course.

@fjlopez Yes, I'm talking about the SRS of the BBOX. Is there any other parameter related with coordinates in the database? I have not seen it. I'd also like to ask if there is expected to show the content of this generic table (default language, SRS,...) in the administrator interface (maybe in a corner of the Dashboard or so?)

fjlopez commented 3 years ago

@lucenasj With https://github.com/sitmun/sitmun-backend-core/issues/99 this is fixed

montsemarco commented 3 years ago

The administrator let me put dots (.) but also commas (,). Is this behaviour correct or it should be restricted to just commas or dots?

fjlopez commented 3 years ago

@montsemarco I just tested that if you use in the UI dots or commas for the decimal point, the request to the server contains always a valid JSON number (i.e where the decimal point is a dot) equivalent to the number entered in the UI control.

montsemarco commented 3 years ago

@fjlopez, with your explanation, I understand that the own interface corrects the inconsistency, hence, I consider the issue as solved