search

sitn / crdppf_core

Core / generic parts of the CRDPPF project
GNU General Public License v3.0
1 stars 3 forks source link

Dbconfigadmin #19

Closed voisardf closed 9 years ago

voisardf commented 9 years ago

@kalbermattenm : You'll probably kill me for this major revision in one chunk, but could you please review ? thanks!!! there is a lot of commented code in admin_functions.py because in a first step I did not yet implement the filtering there

kalbermattenm commented 9 years ago

Done with review... I did not test anything... So it only eye-job...

You have quite a lot of parse lines which are commented in your code, notably Ext object/properties. I don't know if you plan to "uncomment" them... If not, I really think you should delete them...

voisardf commented 9 years ago

this PR is dependens on other modifications in the specific part, so DON'T apply unless you know what you're doing or got the instructions to do so... :)