search

sitn / crdppf_core

Core / generic parts of the CRDPPF project
GNU General Public License v3.0
1 stars 3 forks source link

Tilesfix #36

Closed voisardf closed 9 years ago

voisardf commented 9 years ago

@kalbermattenm : could you give it a very quick glance. Thanks

kalbermattenm commented 9 years ago

You use node.attributes['format'] in layerTree.js, but in your Python files, you use tile_format as list key, thus I don't get how the ink between keys format and tile_format is made ?

I also don't really get what the changes in model.py have to do with the WMTS tiles...?

voisardf commented 9 years ago

models.py is a fix that ended up in this PR because I didn't branch from master by mistake. But for the two lines I didn't want to undo the action.

voisardf commented 9 years ago

@kalbermattenm: I cleaned up the differences between python and js - meaning I removed the parts that weren't used and generalized most of the hardcoded bits. For the rest issue #38 is needed. thanks for reviewing

kalbermattenm commented 9 years ago

OK, just a minor comment, but in my opinion #38 is a WIP...

voisardf commented 9 years ago

comment addressed. merging. thanks.