Update CPotree - Githubissues

sitn / pytree

The potree python server application

8 stars 10 forks source link

Update CPotree #26

Closed maltaesousa closed 1 year ago

maltaesousa commented 1 year ago

This PR:

Deletes binaries from this repo
Build binaries in Docker
Makes docker-compose depend on an pre-built image https://hub.docker.com/repository/docker/sitn/pytree

Working on prepub

maltaesousa commented 1 year ago

@kalbermattenm I agree with you, that's why docker-compose.yml depends on sitn/pytree:1.0 which is the compiled image on dockerhub. When you clone our repo, a docker-compose up will never compile a newer version by default. You have to do it on purposes with a docker build -t sitn/pytree:<version> . and then push it to docker hub. I'll add that to the readme by the way.

kalbermattenm commented 1 year ago

Oh, thanks! I missed the docker-compose.yml instructions, sorry!