kfujinuma
commented
5 years ago Thank you for your report. We will reproduce the problem and check it. Is JpaRepositories of your project that of spring-data-jpa?
Open Lyannic opened 5 years ago
kfujinuma
commented
5 years ago Thank you for your report. We will reproduce the problem and check it. Is JpaRepositories of your project that of spring-data-jpa?
Lyannic
commented
5 years ago Yes, my Repository-Interfaces are extending the one of spring-data-jpa.
kfujinuma
commented
5 years ago Unfortunately, I could not reproduce the same exception in a project using JpaRepository. However, in your project, I think that SIT-CV could not grasp the dependence on spring-data-jpa. So would you show us the build.gradle if possible so that we can reproduce the failure of that dependency?
Lyannic
commented
5 years ago Originally my build.gradle looked like this:
buildscript {
repositories {
mavenCentral()
}
}
plugins {
id 'io.spring.dependency-management' version '1.0.7.RELEASE'
id 'io.sitoolkit.cv.sit-cv-gradle-plugin' version '1.0.0-beta.2'
}
project.ext {
springBootVersion = '2.1.2.RELEASE'
}
group = 'net.my.group'
allprojects {
version = '0.0.1-SNAPSHOT'
}
subprojects {
repositories {
mavenCentral()
}
apply plugin: 'java'
apply plugin: 'io.spring.dependency-management'
group = 'net.my.group.project'
sourceCompatibility = '11'
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-web'
}
dependencyManagement {
imports { mavenBom("org.springframework.boot:spring-boot-dependencies:${springBootVersion}") }
}
}
configure(subprojects - project(':docs')) {
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.9.8'
runtimeOnly 'org.springframework.boot:spring-boot-devtools'
runtimeOnly 'org.postgresql:postgresql'
testImplementation 'org.springframework.boot:spring-boot-starter-test'
testImplementation 'org.springframework.restdocs:spring-restdocs-mockmvc'
}
}But I also tried to make all dependencies available to all projects using this modified version:
buildscript {
repositories {
mavenCentral()
}
}
plugins {
id 'io.spring.dependency-management' version '1.0.7.RELEASE'
id 'io.sitoolkit.cv.sit-cv-gradle-plugin' version '1.0.0-beta.2'
}
project.ext {
springBootVersion = '2.1.2.RELEASE'
}
group = 'my.group'
allprojects {
repositories {
mavenCentral()
}
apply plugin: 'java'
apply plugin: 'io.spring.dependency-management'
version = '0.0.1-SNAPSHOT'
sourceCompatibility = '11'
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.9.8'
runtimeOnly 'org.springframework.boot:spring-boot-devtools'
runtimeOnly 'org.postgresql:postgresql'
testImplementation 'org.springframework.boot:spring-boot-starter-test'
testImplementation 'org.springframework.restdocs:spring-restdocs-mockmvc'
}
dependencyManagement {
imports { mavenBom("org.springframework.boot:spring-boot-dependencies:${springBootVersion}") }
}
}
subprojects {
group = 'my.group.project'
}I just noticed that the bootJar task of my two spring-boot-apps in this multi module project fail when I use your plugin in my project.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':docs:bootJar'.
> java.lang.IllegalArgumentException (no error message)When I just remove the plugin (id 'io.sitoolkit.cv.sit-cv-gradle-plugin' version '1.0.0-beta.2'), it works again. So this might be some kind of dependency problem, because your project relies on Spring Boot aswell.
kfujinuma
commented
5 years ago UnsolvedSymbolException has been reproduced in my environment. The cause seems to be a bug of SIT-CV. I have fixed it, so please try the following fixed version to see if the problem is solved. https://github.com/sitoolkit/sit-cv/tree/feature/fix_unsolvedsymbol
git clone -b feature/fix_unsolvedsymbol https://github.com/sitoolkit/sit-cv.git
cd sit-cv
mvnw install
cd sit-cv-gradle-plugin
gradlew installbuild.gradle
buildscript {
repositories {
mavenlocal()
}
dependencies {
classpath "gradle.plugin.io.sitoolkit.cv:sit-cv-gradle-plugin:1.0.0-beta.4-SNAPSHOT"
}
}
apply plugin: "io.sitoolkit.cv.sit-cv-gradle-plugin"Also, can you try to see if bootJar also fails when using the above plug-in version? (1.0.0-beta.4-SNAPSHOT uses a newer version of Spring)
Lyannic
commented
5 years ago You also need to have the com.sun:tools:1.5.0 jar in $JAVA_HOME/../lib and the gradle install tasks puts the plugin to ".m2/repository/io/sitoolkit/cv/sit-cv-gradle-plugin/1.0.0-beta.4-SNAPSHOT", but gradle looks for it in ".m2/repository/gradle/plugin/io/sitoolkit/cv/sit-cv-gradle-plugin/1.0.0-beta.4-SNAPSHOT".
After sorting this out, the cvReport task and the bootJar tasks run without any problem.
Thank you.
Lyannic
commented
5 years ago Hello, do you already know a approximate release date of version 1.0.0-beta.4? kind regards
Am Fr., 15. März 2019 um 05:25 Uhr schrieb kfujinuma < notifications@github.com>:
Also, can you try to see if bootJar also fails when using the above plug-in version? (1.0.0-beta.4-SNAPSHOT uses a new version of Spring)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sitoolkit/sit-cv/issues/86#issuecomment-473154364, or mute the thread https://github.com/notifications/unsubscribe-auth/ARDkxprVifgovB5yxG3e4NVdch1xWrB6ks5vWyDFgaJpZM4bhEyV .
ykuwahara
commented
5 years ago @Lyannic We released v1.0.0-beta.4 just today!
Lyannic
commented
5 years ago Thank you very much for your reply
On Sun, 4 Aug 2019, 11:24 Yuichi Kuwahara, notifications@github.com wrote:
@Lyannic https://github.com/Lyannic We released v1.0.0-beta.4 just today!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sitoolkit/sit-cv/issues/86?email_source=notifications&email_token=AEIOJRQMSSBXOPMHTRIHVG3QC2N6NA5CNFSM4G4EJSK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3P5ZJY#issuecomment-517987495, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIOJRTKKX3QZXMJXA54N5LQC2N6NANCNFSM4G4EJSKQ .
Lyannic
commented
2 years ago I didn't manage to try out the official release till now. But I get the same error with 1.1.1 and also with the official 1.0.0-beta.4.
Hello, when I try to execute the cvReport task for a project that contains JpaRepositories, I get the following exception:
When I delete the JpaRepositories from the project, everything works fine. Do you have any idea, why it can't handle them?
Thank you in advance for any help.