Closed ghost closed 9 years ago
I see some code still copied from other module, so need updates
please add updated sqldump in data/sql for now, in the future, I think we can use doctrine migrations.
please undo updated composer.phar
besides of some cs issues above, please add unit tests and web acceptance tests.
Why continuous-integration/travis-ci/pr fails? :/
please check travis detail, click the travis link...
Warm regards,
Abdul Malik Ikhsan
Pada 28 Apr 2015, pukul 01.02, Stanimir Dimitrov notifications@github.com menulis:
Why continuous-integration/travis-ci/pr fails? :/
— Reply to this email directly or view it on GitHub.
coveralls still not 100% :
- 39.29% module/LearnZF2Authentication/Module.php
- 100.00% module/LearnZF2Authentication/config/module.config.php
- 66.67% module/LearnZF2Authentication/src/LearnZF2Authentication/Controller/IndexController.php
- 100.00% module/LearnZF2Authentication/src/LearnZF2Authentication/Factory/BasicAuthenticationAdapterFactory.php
please make it 100%, open ./data/test-html-report/learnzf2authentication/index.html
for check what parts that need to be improved.
I keep getting error messages from travis-ci for all modules such as: Doctrine\DBAL\Driver\PDOException: SQLSTATE[HY000] [2002] No such file or directory Zend\ServiceManager\Exception\ServiceNotCreatedException: An exception was raised while creating "doctrine.entitymanager.orm_default"; no instance returned
which means that there is no server started?
I will re-start travis build and let see what will happen ;)
Finally! I will review everything from work one more time and will give you a green light to merge everything. Thanks for your help!
I will reduce the code even more, when I get home and give you a green light
ready to be merged ?
yes.
it's merged, thank you. I've uploaded in http://learnzf2.sitrun-tech.com/learn-zf2-authentication . Seems authentication always failed even username and password is right in shared hosting. I am checking if there is a special config for it for shared hosting
@Stanimirdim92 if you know about shared hosting setting for this, please let me know, otherwise, I probably will add a note in the module that it currently don't work in current hosting, need to try in local... Thanks.
Alright. I will look around and let you know. Can you give me the shared hosting url?
Ok, this is the url http://learnzf2.sitrun-tech.com/learn-zf2-authentication .
Warm regards,
Abdul Malik Ikhsan
Pada 1 Mei 2015, pukul 14.13, Stanimir Dimitrov notifications@github.com menulis:
Alright. I will look around and let you know. Can you give me the shared hosting url?
— Reply to this email directly or view it on GitHub.
My guess is that it's not sending the Auth header. Is .htaccess allowed?
Yes :), but probably not all functionality. Need vps, but more cost :(
Warm regards,
Abdul Malik Ikhsan
Pada 1 Mei 2015, pukul 15.58, Stanimir Dimitrov notifications@github.com menulis:
My guess is that it's not sending the Auth header. Is .htaccess allowed?
— Reply to this email directly or view it on GitHub.
@Stanimirdim92 I've submitted a ticket to hosting provider, hopefully they can help about it.
@Stanimirdim92 finally, it worked \m/, I've hacked it, see https://github.com/sitrunlab/LearnZF2/commit/c65f9086b303cae46d050a401d68b0c1a52f9a1b .
Thank you for the contributions ;)
Cool! Can this actually be included in ZF2?
P.S I already have some idea for new tutorials such as database connections, login/registration form ;)
hopefully! this issue already reported in zf2 repo : https://github.com/zendframework/zf2/issues/5873 Awesome, Thank you ;)
I still have to create a view and test the digest authentication.