search

sitrunlab / LearnZF2

Learn ZF2 Website
http://learnzf2.sitrun-tech.com/
BSD 3-Clause "New" or "Revised" License
19 stars 14 forks source link

add doctrine migration support #130

Closed samsonasik closed 9 years ago

samsonasik commented 9 years ago

so, as new module added, we can generate new migration file and add sql insert into new generated file, and can migrate for pulled new module.

samsonasik commented 9 years ago

ready for review

acelaya commented 9 years ago

That's a great addition. I'll try to test it this evening.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 11/5/2015 12:32 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

ready for review

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-100861709.

samsonasik commented 9 years ago

thanks ;)

acelaya commented 9 years ago

Sorry, I just realized that I forgot to test this yesterday :( I have a local PUG meet-up today, so I won't be able to do it, but I'll test it tomorrow.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 11/5/2015 1:09 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

thanks ;)

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-100870378.

samsonasik commented 9 years ago

it's ok, take your time. Thank you ;)

Warm regards,

Abdul Malik Ikhsan

Pada 12 Mei 2015, pukul 12.11, Alejandro Celaya notifications@github.com menulis:

Sorry, I just realized that I forgot to test this yesterday :( I have a local PUG meet-up today, so I won't be able to do it, but I'll test it tomorrow.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 11/5/2015 1:09 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

thanks ;)

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-100870378.

— Reply to this email directly or view it on GitHub.

ghost commented 9 years ago

I'm quite busy this week, but I will test it this weekend.

ghost commented 9 years ago

Please, update ZF2 to version 2.4.2. :)

samsonasik commented 9 years ago

~2.4.0 in composer.json will update to latest maintenance release on composer update based on http://framework.zend.com/long-term-support .

Warm Regards,

Abdul Malik Ikhsan

2015-05-13 1:06 GMT+07:00 Stanimir Dimitrov notifications@github.com:

Please, update ZF2 to version 2.4.2. :)

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-101369791.

samsonasik commented 9 years ago

merge-able ?

acelaya commented 9 years ago

I'm sorry, this has been a week with not too much free time. I should be able to test this tomorrow.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 15/5/2015 9:56 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

merge-able ?

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-102509015.

samsonasik commented 9 years ago

ok :+1:

acelaya commented 9 years ago

I'm testing this. It looks great, but I'm getting an error while running any migrations command, like vendor/bin/doctrine-module migrations:migrate. It says this:

[InvalidArgumentException]                                    
There are no commands defined in the "migrations" namespace.

I think that migrations is not integrated in the DoctrineModule in version 0.8, could it be? However I think it is planned to be integrated in version 1.0.0

acelaya commented 9 years ago

Confirmed. Migrations has been added to version 0.9 https://github.com/doctrine/DoctrineORMModule/releases/tag/0.9.0

acelaya commented 9 years ago

Also, trying to test this in master doesn't help too much... My bad. Under the proper branch it works good!

samsonasik commented 9 years ago

that should be resolved by composer update. Should we use 0.9.* instead ?

acelaya commented 9 years ago

I don't know. It seems that there is some kind of support in version 0.8 too.

Maybe we can create another ticket in order to update DoctrineORMModule's version.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 16/5/2015 8:09 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

that should be resolved by composer update. Should we use 0.9.* instead ?

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-102660442.

samsonasik commented 9 years ago

Ok, I'm going to merge this for now. Thank you.

Warm regards,

Abdul Malik Ikhsan

Pada 17 Mei 2015, pukul 01.22, Alejandro Celaya notifications@github.com menulis:

I don't know. It seems that there is some kind of support in version 0.8 too.

Maybe we can create another ticket in order to update DoctrineORMModule's version.

Alejandro Celaya Alastrué www.alejandrocelaya.com El 16/5/2015 8:09 p. m., "Abdul Malik Ikhsan" notifications@github.com escribió:

that should be resolved by composer update. Should we use 0.9.* instead ?

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/130#issuecomment-102660442.

— Reply to this email directly or view it on GitHub.