search

sitrunlab / LearnZF2

Learn ZF2 Website
http://learnzf2.sitrun-tech.com/
BSD 3-Clause "New" or "Revised" License
19 stars 14 forks source link

module learnzf2captcha #137

Closed samsonasik closed 9 years ago

samsonasik commented 9 years ago

I'm sorry for the delay, was so busy. I will be on holiday on 10 - 27 July, hopefully can do it after that

samsonasik commented 9 years ago

I am thinking to add recaptcha adapter to config/captcha.config.php, but it will take more step for user to get it works. So I only include 2 of the adapters. any idea ?

acelaya commented 9 years ago

Yes, it is probably too complicated to create a recaptcha example. The live demo has to be funcitonal, so we would need to have two app keys, but it is not a good idea to let them to be downloaded by anyone :-) I think it is good enough to use the image and dumb/figlet adapters.

samsonasik commented 9 years ago

done ;). ready for review ;) zf2-captcha-demo I increased php requirement version to 5.5 ( probably temporary ) due to codeception requirement guzzle issue and updated some codeception tests due failed tests button onclick (I will check if possible).

To check locally, we can run:

vendor/bin/doctrine-module migrations:migrate

to insert new data based on added migration file.

ghost commented 9 years ago

You have a green light from me! Checked the code and didn't find anything wrong. I even learned two new things :D

Edit:

Maybe add a form->ElementErrors() or w/e the name was and a submit button to notify the user if something went wrong, like entering a wrong captcha?

samsonasik commented 9 years ago

@Stanimirdim92 done ;). added submit button and form validation. zf2-captcha-add-submit-and-form-validation

ghost commented 9 years ago

gtg

samsonasik commented 9 years ago

merged. @acelaya @Stanimirdim92 thanks for the review ;) master:https://github.com/sitrunlab/LearnZF2/commit/3db573743191df617b588758268f1fda134cbd16 develop: https://github.com/sitrunlab/LearnZF2/commit/78308ce4b02ec1e0886d95c81a913ea7a521e15a