sitrunlab / LearnZF2

Learn ZF2 Website
http://learnzf2.sitrun-tech.com/
BSD 3-Clause "New" or "Revised" License
19 stars 14 forks source link

initial db usage for module list #69

Closed samsonasik closed 9 years ago

samsonasik commented 9 years ago

in favor of #53 , I am working on initial db usage with module list.

samsonasik commented 9 years ago

ready for review ;)

acelaya commented 9 years ago

Looks good to me ;)

samsonasik commented 9 years ago

travis build failure cause connect db, I'll try to setup database at travis like this : http://docs.travis-ci.com/user/database-setup/#MySQL

samsonasik commented 9 years ago

database setted up. I don't know why 'vendor/' folder now included in phpunit coverage even I exlude it in phpunit.xml, I'm going to find a way to fix it, ... and new entity still need test.

acelaya commented 9 years ago

Maybe using a whitelist instead of a blacklist?

samsonasik commented 9 years ago

I tried with whitelist but still no luck, could you test it ?

acelaya commented 9 years ago

Of course. I think I had to fix this same issue in the past, but I can't remember how I did it. Let me check.

samsonasik commented 9 years ago

ok, you can make a PR to my branch if you found the solution. thanks ;)

Warm Regards,

Abdul Malik Ikhsan

2014-12-05 22:07 GMT+07:00 Alejandro Celaya notifications@github.com:

Of course. I think I had to fix this same issue in the past, but I can't remember how I did it. Let me check.

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/69#issuecomment-65801799.

samsonasik commented 9 years ago

I think I know the reason for vendor doesn't excluded, it because I did wrong type for folder jumping : ./../vendor/ inside module test directory. Will commit in a few.

samsonasik commented 9 years ago

I have fixed the vendor/ exclude from the coverage. If anyone know the right way to mock the entity in test, please let us know, thank you ;)

acelaya commented 9 years ago

I have created ObjectManager and ObjectRepository mocks for other projects, but I'm not sure if that's what you mean.

https://github.com/zasDev/zasdev-reader/tree/develop/mocks/Doctrine

Alejandro Celaya Alastrué www.alejandrocelaya.com El 5/12/2014 22:53, "Abdul Malik Ikhsan" notifications@github.com escribió:

I have fixed the vendor/ exclude from the coverage. If anyone know the right way to mock the entity in test, please let us know, thank you ;)

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/69#issuecomment-65860564.

samsonasik commented 9 years ago

thank you, I will check it.

samsonasik commented 9 years ago

I've added entity test, I doubt why the entity test still not included in coverage, will merge as is for now and open for new PR if got the solution ;)

samsonasik commented 9 years ago

merged : to : master https://github.com/sitrunlab/LearnZF2/commit/7aed8ceeed71bf523b050534b4b26a5115ad14ad Forward to : develop https://github.com/sitrunlab/LearnZF2/commit/585a6cd43396a9c32d956a767db10ff428e54d5d