search

sitrunlab / LearnZF2

Learn ZF2 Website
http://learnzf2.sitrun-tech.com/
BSD 3-Clause "New" or "Revised" License
19 stars 14 forks source link

contributors page #74

Closed samsonasik closed 9 years ago

samsonasik commented 9 years ago

update :
1 console command to get contributors : 1-contributor 2 the page view 2-the-page

acelaya commented 9 years ago

Awesome! Looks really good.

samsonasik commented 9 years ago

thanks, not sure about testing consolecontroller as testing access make call to github api make limited access. ready for review ;)

acelaya commented 9 years ago

Maybe the http client or at least the adapter should be injected. We could use the Test adapter and a hard-coded github response just to make sure our code works. What do you think?

Alejandro Celaya Alastrué www.alejandrocelaya.com El 14/12/2014 15:58, "Abdul Malik Ikhsan" notifications@github.com escribió:

thanks, not sure about testing consolecontroller as testing access make call to github api make limited access. ready for review ;)

— Reply to this email directly or view it on GitHub https://github.com/sitrunlab/LearnZF2/pull/74#issuecomment-66915662.

samsonasik commented 9 years ago

Yes, I will try to inject the adapter. oh, yes, there is Test adapter, I will try it.

samsonasik commented 9 years ago

I've added test for ConsoleController using Test Adapter. not 100% tested for now but I think it is ok for now ;)

acelaya commented 9 years ago

I like how it looks now.

samsonasik commented 9 years ago

@mockiemockiz thanks for the design @acelaya thanks for the recommendation.

It's merged to master : https://github.com/sitrunlab/LearnZF2/commit/3ca63bf1b1822cb3e730507d11ac6b5e8c08e061 Forwarded to develop : https://github.com/sitrunlab/LearnZF2/commit/c36303c1d3750f19f70f47458b7aa89b463cc0ba

Awesome. It's online now : http://learnzf2.sitrun-tech.com/contributors ;)