search

sitya / samlidp

SAML Identity Provider as a Service
GNU General Public License v3.0
11 stars 11 forks source link

samlidp-start.sh handles neither signals nor zombie processes #8

Open edysli opened 5 years ago

edysli commented 5 years ago

The startup script samlidp-start.sh defined as CMD in the Dockerfile starts several processes (I spotted rsyslogd and nginx) but neither propagates signals to them nor handles eventual zombie processes these may create. The solution to this is to use a lightweight init program as PID 1 in your container to start other processes.

See Docker - init, zombies - why does it matter? and Docker and the PID 1 zombie reaping problem for a detailed explanation of the problem.

sitya commented 5 years ago

Thanks for your suggestion, I will go through the articles, then we will see what to implement.

edysli commented 5 years ago

The image you are using as a base richarvey/nginx-php-fpm uses supervisord to run nginx, so you can reuse it for free for your processes. :smiley: