search

siv2r / kidney-exchange

A platform to facilitate automized inter-hospital kidney transplants.
https://ke.iitm.ac.in/kidney-exchange/
GNU General Public License v3.0
47 stars 104 forks source link

added eye icon #327

Closed ayushseth07 closed 3 years ago

ayushseth07 commented 3 years ago

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

fixes #324

image

siv2r commented 3 years ago

@ayushseth07 I noticed that there is already a showPassword.js file. So you can put your new function in this instead of creating a showPassoword2.js. I asked you to create a new .js file last time. Sorry for the wrong suggestion. I didn't know that showPassword.js already existed.

Also, you don't need to create a new PR every time. Just update the local branch and git push which will automatically update this PR.

siv2r commented 3 years ago

@ayushseth07 Everything looks amazing!! Did you test the working of new changes?

ayushseth07 commented 3 years ago

@siv2r yes i have tested them and they are working fine

welcome[bot] commented 3 years ago

Congrats 🎉 on merging your first pull request. Congratulations on merging your first contribution to kidney-exchange✨

siv2r commented 3 years ago

@ayushseth07 Thanks for this amazing PR :tada: :tada: