search

siv2r / kidney-exchange

A platform to facilitate automized inter-hospital kidney transplants.
https://ke.iitm.ac.in/kidney-exchange/
GNU General Public License v3.0
47 stars 104 forks source link

Delete createPR.md #401

Closed codercool3r closed 2 years ago

codercool3r commented 2 years ago

Modified the description for the pull request guide and the first-timers guide

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Addresses # (issue) - use this if your pull request solves only a part of the issue

How did you test your changes?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

....

welcome[bot] commented 2 years ago

Hi Welcome to kidney-exchange!💖, Thanks for opening this pull request🌸 Please check out our contributing guidelines✨.

codercool3r commented 2 years ago

Modified the description for the pull request guide and the first-timers guide

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Addresses # (issue) - use this if your pull request solves only a part of the issue

How did you test your changes?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

....

I have done this under GSSOC'22

siv2r commented 2 years ago

Hey, thanks for the PR. There is already a docs/newContributors.md which does this job.

You can simply delete the docs/createPR.md file. That is a good change to do.

codercool3r commented 2 years ago

Hey, thanks for the PR. There is already a docs/newContributors.md which does this job.

You can simply delete the docs/createPR.md file. That is a good change to do.

Oh, sorry about that, since the files had different content, I figured its better to add it. I will remove the file.

siv2r commented 2 years ago

You don't need to close this PR. You can just update your current git branch and force push. This will update your PR on GitHub.

codercool3r commented 2 years ago

Can you check now

siv2r commented 2 years ago

Changes looks good! Can you squash your commits (from 4 commits to one )?

codercool3r commented 2 years ago

Changes looks good! Can you squash your commits (from 4 commits to one )? I have squashed, but I am not able to check if it actually happened. Can you please confirm

siv2r commented 2 years ago

No, the squash is not reflected. You need to force push (git push -f origin branch-name) after squashing your commits.

codercool3r commented 2 years ago

No, the squash is not reflected. You need to force push (git push -f origin branch-name) after squashing your commits.

Done, thank you soo much for being patient with my questions, even if this was a very minor pull request. :) Also, Sorry for kinda messing things up.

siv2r commented 2 years ago

Also, Sorry for kinda messing things up.

No worries, that is part of the learning process :)

Also, the changes in the README are included again 😂. Can you remove those changes?

codercool3r commented 2 years ago

Actually, I am not able to find any method to remove the changes. Can you help me out?

codercool3r commented 2 years ago

Actually, since this is just a minor issue, and also I am not able to figure it out. I am closing this pull request, sorry for all the unnecessary chaos.