search

sivajik34 / Custom-Fee-Magento2

extra fee :Using this extension you can add custom extra fee such as insurance fee,delivery sign fee etc at checkout.
40 stars 27 forks source link

composer changes #4

Open jaykobi opened 7 years ago

jaykobi commented 7 years ago

Hi,

first of all a big thank you for uploading that module! I already use it and it does it's job well.

To make it installable with composer directly you should have composer.json in the root directory. In fact, I think best practice is to put alle the code you now have under Sivajik34/CustomFee in the root directory directly. Composer will take take of creating those directories during installation.

Also the dependency for magento framework is out of date ("magento/framework": "~100.0.4"). I just installed with magento 2.1.3 and it worked so you should consider updating this, or composer will not let anybody install it.

Thanks for the great work.

sivajik34 commented 7 years ago

Thank you for your feedback,i don't have enough time to work on this.you can contribute by forking the repo,make pull request.