sivarajankumar / contentflow

Automatically exported from code.google.com/p/contentflow
0 stars 0 forks source link

Breaks when the script is not loaded on its own #5

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Try putting the script (and the addons) into a file together with other
stuff like you would do in a production environment
2.
3.

What is the expected output? What do you see instead?

The script assumes that it should always load the addons buy adding script
tags and the css files, too. This is of course wrong and should not happen
when everything (all JS files) are compressed into one script. Under this
assumption the script throws an error and nothing works anymore (as
scriptElement.src isn't defined).

What version of the product are you using? On what operating system?

Version 1.0.2

Please provide any additional information below.

The attached diff fixes this by only trying to load additional files when
this is actually possible,

Original issue reported on code.google.com by urban.ha...@gmail.com on 7 May 2010 at 12:52

Attachments:

GoogleCodeExporter commented 8 years ago
Brilliant. This patched worked for me with my rails app.

contentflow shouldn't force css/js to be loaded separately for addons. That's 
so Web 0.9.

Original comment by jer...@jaguardesignstudio.com on 7 Aug 2012 at 8:58