search

sivarajankumar / google-gadgets-for-linux

Automatically exported from code.google.com/p/google-gadgets-for-linux
Apache License 2.0
0 stars 0 forks source link

ggadget/tests/test_modules/CMakeLists.txt wrongly set CMAKE_SHARED_LINKER_FLAGS #229

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In ggadget/tests/test_modules/CMakeLists.txt, there is a line:

SET(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -module")

it is not needed and it is wrong. IMHO, there is already a 
CMAKE_MODULE_LINKER_FLAGS environment to link modules, there is no use 
redefining SHARED_LINKER_FLAGS, as it will only be used when linking 
shared libaries, such as libggadget-1.0.so.0

Original issue reported on code.google.com by fundawang@gmail.com on 25 Oct 2008 at 1:34

GoogleCodeExporter commented 8 years ago 
Thank you for you report. Are you familiar with cmake system? Are you 
interested in
helping us improve cmake script?

Original comment by james...@gmail.com on 25 Oct 2008 at 3:38

GoogleCodeExporter commented 8 years ago 
This was left undeleted when we added ADD_MODULE macro. Thank you for your 
report.

Original comment by phnix...@gmail.com on 27 Oct 2008 at 5:00

GoogleCodeExporter commented 8 years ago

Original comment by phnix...@gmail.com on 27 Oct 2008 at 7:42