search

sivertschou / dundring

dundring.com is a free and open source in-browser training application created to control and track your training with a smart bike trainer⚡️
https://dundring.com
Apache License 2.0
62 stars 8 forks source link

Upload activity to Strava #395

Closed morteako closed 1 month ago

morteako commented 2 months ago

Basically implemented, but needs some better design for the upload, link and the extra authorize-strava-button

sivertschou commented 1 month ago

Remember to update granted scopes after auth – no matter even if the user already exists or not

sivertschou commented 1 month ago

Removed the Connect to Strava-prompt in the main action bar, and moved that functionality to the profile page. Think it makes more sense to add that kind of prompt where you are done with a workout, and that should not be done until we have some persistent storage of the data (#364) 😅

image
sivertschou commented 1 month ago

Design of the main action bar after changes:

image image image image

edit: see a typo here – will fix

morteako commented 1 month ago

Great polish and good fixes! I agree with the comments and also that is a seperate PRs. Good to get this merged 😅