search

sivy / pystatsd

Python implementation of the Statsd client/server
http://pypi.python.org/pypi/pystatsd/
BSD 2-Clause "Simplified" License
358 stars 87 forks source link

Timing is expected in ms, but timing_since sends μs. #94

Closed ddinchev closed 2 years ago

ddinchev commented 9 years ago

Fixing a bug reported in number of issues so far: Fixes #31 Fixes #44 Fixes #93

Unit test was also measuring μs while it says it's measuring ms. Maybe the interface of the timing_since method shouldn't be seconds at all - for consistency it should be milliseconds for all timing methods. I can change it, what do you think?

jamescooke commented 9 years ago

Looks good to me.

tayfun commented 7 years ago

We should merge this :)

ddinchev commented 7 years ago

@tayfun this is 2.5 years old. I doubt it's getting anywhere.