six-pack / Axis-Mundi

A secure, resilient, distributed and open communication platform.
59 stars 21 forks source link

Local database is not encrypted #3

Closed six-pack closed 9 years ago

six-pack commented 9 years ago

This release of the code is temporarily configured to produce an unencrypted local sqlite database.

This is to make debugging considerably easier. If you want the local database encrypted then you will need to comment out line 92 and uncomment line 91 in storage.py

Line 91 should read: self.engine = create_engine('sqlite+pysqlcipher://:' + passphrase + '/' + dbfilepath)

I will add a test/debug option to client.py to enable unencrypted databases for testing and default to encrypted unless otherwise specified.

Ricardo-Spanish commented 9 years ago

As the database schema is getting more stable maybe now is the time to enable encryption by default. We could use the new test_mode flag to run with a clear database for testing and dev. What do you think?

six-pack commented 9 years ago

I think once listings and the ordering schema is in we should do it. I'm always in and out of the db at the moment.

Ricardo-Spanish commented 9 years ago

Ordering schema is now in. I have now pushed a small commit ( 66ce7234864c202a48d76246da301da2ac8cbe61 ) to re-enable database encryption.

It needs to be tested on Windows but works fine on Linux & MacOS

Closing as fixed