search

six-two / qr.html

A standalone offline HTML5 QR code generator
https://qr.15c.me
The Unlicense
108 stars 34 forks source link

Redesigned UI #1

Closed sagarparmar881 closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/six-two/qr-html/7BR4aVzT4DAfZgLxMikBGvRNeUZc
✅ Preview: https://qr-html-git-fork-sagarparmar881-master-six-two.vercel.app

six-two commented 3 years ago

Hi Sagar Parmar, thank you for your PR. I have reviewed your changes. Sadly, I have come to the conclusion that they do not match with my plans for the project.

The goal was to make a QR code generator, that works well for large contents. Thus I maximized the size of the QR code and the text input. Your changes do not work will in this regard (see screenshot below).

qr-gen-pr

It was also designed to be in a single small file, that is quick and easy to dowload and transfer to other systems (eg via SCP, USB Stick, etc). Thus putting the CSS in a extra file (while a common practice) also goes against my design goals.

Best regards six-two