search

six-two / qr.html

A standalone offline HTML5 QR code generator
https://qr.15c.me
The Unlicense
108 stars 34 forks source link

Misc clean-up #4

Closed kurahaupo closed 9 months ago

kurahaupo commented 9 months ago

Fix typos. Improve phrasing ("no longer ... buggy" seems wrong) Use italics rather than <brackets> for placeholders Trim whitespace

six-two commented 9 months ago

Hi, thank you for your PR!

I looked over your changes and they seem good.

The only issue I see is with the replacement of the inline code with <tt> tags (which I did not know even existed). A quick search seems to indicate that they are deprecated and should not be used anymore (Source: caniuse, w3schools). So I would replace them with <code> elements, unless you have a better idea.

six-two commented 9 months ago

I replaced the <tt> tags with <code>. And since I found it hard to see what is italic, I changed the formatting to bold. With that it should be good to merge. Thanks again for the PR :smile:

kurahaupo commented 8 months ago

Since it's not specifically keyboard (tty) input, I should have used <code> rather than <tt>. (And even if it were keyboard input, I should have used the more modern <kbd>. Time to kill some old habits...)

Likewise I should have used <var> rather than <i>, which then leaves it up to the user how they want that styled.