search

six2six / fixture-factory

Generator fake objects from a template
Apache License 2.0
445 stars 88 forks source link

email() method not working properly #111

Open guilherme-lima opened 4 years ago

guilherme-lima commented 4 years ago

Looking at class RandomGen, line 124 we have this method:

public static String email(Integer emailLength, String domain)

When its variable emailLength is less then 12, an IllegalArgumentException will be thrown at class RandomStringUtils, line 48:

public static String random(int count, int start, int end, boolean letters, boolean numbers, char[] chars, Random random)

else if (count < 0) throw new IllegalArgumentException("Requested random string length " + count + " is less than 0.");

The only way to avoid this error is using one of the other signatures where you can pass the emailLength, but it must be higher or equals 12.

atif-github-venture commented 3 years ago

Hi.. can I work on this solution, will you be accepting the PR in time? Our team needs this for an academic project.

pkatre2 commented 2 years ago

can you assign it to me , would like to contribute