search

six2six / fixture-factory

Generator fake objects from a template
Apache License 2.0
445 stars 88 forks source link

fix #44: override property definition on `gimme` call #49

Closed jonathanhds closed 10 years ago

nykolaslima commented 10 years ago

@jonathanhds thank you for your pull request. I believe code is fine to merge it.

But ObjectFactory has wrong indentation. Can you please just fix this indentation?

After this fix I will merge it, ok?

I sorry for taking so long to answer.

Thank you again!

jonathanhds commented 10 years ago

Done!

nykolaslima commented 10 years ago

@jonathanhds it still got wrong identation, I think you are using some IDE formatter to format your code and it is making identation wrong.

If you see github diff for ObjectFactory it is showing that your removed all lines and add it again. This way is hard to us to see what did you changed. https://github.com/six2six/fixture-factory/pull/49/files#diff-5aff307f919a7fe4fe3e67f2fcccb6a5L29

Can you please keep the old identation and just modify what you need in ObjectFactory class?

jonathanhds commented 10 years ago

You are right, @nykolaslima. I was using Intellij IDEA that uses another code formatter. I've applied the Eclipse's code formatter on files that I've changed. See if it's right for you.

nykolaslima commented 10 years ago

@jonathanhds will you open another pull request with your commits with right identation?

If you won't gonna do that, please let me know so I will implement this feature.

Thank you!