search

six2six / fixture-factory

Generator fake objects from a template
Apache License 2.0
445 stars 88 forks source link

Big decimal range #69

Closed csrcordeiro closed 9 years ago

csrcordeiro commented 9 years ago

Hi Fixture Factory community,

This pull request is regarding issue #61. To Implement this, I had to change both the BigDecimal and BigInteger features but I believe it will be ok since I was able to write tests for both cases. I also noticed a little typo in README tutorial so I fixed it.

There are tests failing in master branch but I couldn't figure out what it was about so I didn't fixed it, the tests are:

nykolaslima commented 9 years ago

@csrcordeiro Travis CI ran all tests and nothing failed. I also ran the tests on my machine and the tests you mentioned worked:

Maybe it's a bug? What's your environment? Java version etc.

I only added two little comments about the tests.

csrcordeiro commented 9 years ago

@nykolaslima Here are my environment settings:

The cause is a little bit odd, it seems to be in bytecode level so might be a OS issue:

net.vidageek.mirror.exception.MirrorException: Could not find constructor with args [class br.com.six2six.fixturefactory.model.Immutable] on class br.com.six2six.fixturefactory.model.Immutable$ImmutableInner

I'll try to take a look at the problem a little further.

nykolaslima commented 9 years ago

@csrcordeiro about this MirrorException, I believe we can open a new issue to investigate it. What do you think?

csrcordeiro commented 9 years ago

Ok, I'll just fix the tests assertions.

nykolaslima commented 9 years ago

Thanks @csrcordeiro