search

six2six / fixture-factory

Generator fake objects from a template
Apache License 2.0
445 stars 88 forks source link

Add retrocompatibility to java 6 and 7 #85

Open ismaelgcosta opened 8 years ago

ismaelgcosta commented 8 years ago

Once we added support to java time I thing it's necessary to update the java compiler version

maurcarvalho commented 8 years ago

@mundodojava just make sure to check that, FF should continue working on previous compiler versions such as 1.6 and 1.7. Ty

nykolaslima commented 8 years ago

@mundodojava the build is broken...

ismaelgcosta commented 8 years ago

@MauricioJr I'm just updating tha java version compiler. Because we added support to Java Time. This change already broken the use with Java versions 1.6 and 1.7 .

maurcarvalho commented 8 years ago

This change broken the use with Java versions 1.6 and 1.7.

@mundodojava What does that mean?

Are we affirming that every project wich has been using FF cannot update with the master version? Is it really expected?

Once you did that java.version runtime validation It doesn't make sense to me. If only java-8 compilers will be able to execute FF dependency, why validate they java.version?

ismaelgcosta commented 8 years ago

Ok. I get your point. I added retrocompatibility to java 6 and 7. So validate java.version now makes sense.

ismaelgcosta commented 8 years ago

@nykolaslima Can you merge this? It will be necessary to this release.

ismaelgcosta commented 8 years ago

I`m waiting this merge and the new version to use at my work

ismaelgcosta commented 6 years ago

Hi guys, this PR will be merging?

ismaelgcosta commented 1 year ago

Hi @maurcarvalho @nykolaslima , can you merge this PR ? I fixed all the pointed changes