six8 / pyinstaller-alpine

Docker image that can build single file Python apps with PyInstaller for Alpine Linux.
MIT License
80 stars 44 forks source link

Pyinstaller-3.4 fails to build on Alpine 3.5, 3.7 (bootloader issue) #4

Closed DevOpsJon closed 3 years ago

DevOpsJon commented 5 years ago

I wonder if this project is still active/maintained?

I tried to build it recently and got the following errors. I wonder if anyone else found a workaround yet? I put details here:

https://github.com/pyinstaller/pyinstaller/issues/4196

six8 commented 5 years ago

It's still in use. But I haven't tried with the latest PyInstaller in a while.

I'll see if I can reproduce it.

brezerk commented 5 years ago

yeah. stepped on this as a part of playing around #5 https://circleci.com/gh/brezerk/pyinstaller-alpine/10

brezerk commented 5 years ago

it looks like it is related to GCC 8. It is treating strncat warning as an error:

Apparently GCC understands that strncat(_tempname, "/hellooXXXXXX", 13); is no different from >strcat(_tempname, "/hellooXXXXXX");, and finds it suspicious that you're using former instead of the >latter.

If you can change the code, use strcat instead (or even better, rewrite the thing to use std::string).

If you can't change the code, use -Wno-stringop-overflow flag to disable the warning.

brezerk commented 5 years ago

@DevOpsJon can you test it now? I think it should be resolved :)

alexks02 commented 5 years ago

@brezerk I can do it! (-; P.S. Доброго времени суток!)