search

sixfeetup / scaf

scaf provides developers and DevOps engineers with a complete blueprint for a new project using Kubernetes
BSD 3-Clause "New" or "Revised" License
84 stars 14 forks source link

The development tools should be aligned between Flake.nix and pre-commit #421

Open hillairet opened 1 week ago

hillairet commented 1 week ago

Right now the local setup can be in an annoying situation where the versions of a tool like Black differ between the Nix environment and pre-commit.

The version is pinned in pre-commit (and not to the latest one):

https://github.com/sixfeetup/scaf/blob/78bf22d950efb76ed24051acfba7e165db6091db/.pre-commit-config.yaml#L13

But it's not pinned in Nix therefore it can (and currently is) different:

https://github.com/sixfeetup/scaf/blob/78bf22d950efb76ed24051acfba7e165db6091db/flake.nix#L22

Ideally, there would be some consistency check or simply the version in Nix should be pinned if possible.

hillairet commented 1 week ago

Assigning to you @sedatbasar for visibility.