search

sixletters / pe

0 stars 0 forks source link

DG diagram issue #13

Open sixletters opened 3 years ago

sixletters commented 3 years ago

I dont think it is neccessary to add in class method inside the diagram on the arrow. And on exit may not be a suitable return type or label as well. Screenshot 2020-11-13 at 5.11.34 PM.png Screenshot 2020-11-13 at 5.11.30 PM.png

nus-pe-bot commented 3 years ago

Team's Response

It might not be necessary to add class method, but I think it shows clarity that we are calling a static method from another class, instead of having an object of that class. The "on exit" label is to show that the method returns only when the user exits the program.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not think its correct in a sequence diagram to write label a return arrow as "on exit". The label should be what was returned rather than "on exit".

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]