search

sixones / vitality

Macintosh Eve online skill planner
GNU General Public License v3.0
70 stars 12 forks source link

Update Data? #27

Closed Merovex closed 10 years ago

Merovex commented 10 years ago

I have a toon studying Amarr Industrial V. There are no SP associated with the skill, so it says I effectively have an empty queue. However, I have two weeks remaining.

Bleyddyn commented 10 years ago

I think this is due to a bug in the API itself. It returns a skill queue that has the same value for starting and ending skill points. I have a work-around written and it should be in the next release.

Merovex commented 10 years ago

Cool. Any timeline on when the Rubicon fixes will be in? A bit frustrating to have it impose prereqs that are no longer required.

I do appreciate your taking over from MET. Life is good again.

On Thu, Dec 5, 2013 at 10:45 AM, Bleyddyn notifications@github.com wrote:

I think this is due to a bug in the API itself. It returns a skill queue that has the same value for starting and ending skill points. I have a work-around written and it should be in the next release.

— Reply to this email directly or view it on GitHubhttps://github.com/sixones/vitality/issues/27#issuecomment-29908514 .

Ben Wilson "A belief, no matter how sincere, if not reflected in reality isn’t a belief; it’s a delusion."

Merovex commented 10 years ago

DId you put the release out because now it's showing Amarr Industrial (11d out).

Bleyddyn commented 10 years ago

There haven't been any releases recently. It could be that the data returned by the API is now correct. I don't know what causes the problem but it could be that you got far enough into training the skill that it's now returning the right data.

Merovex commented 10 years ago

Interesting that you came to the same likely conclusion...that the API finally returned a value that Vitality could process. I'm not familiar enough with the language or its layout to try to figure out where it's happening. I would assume that Vitality is freaking out and defaulting to zero for remaining Skill Points. Could it be based on the size of a variable (int v. large int)? The skill itself is 842K above Level VI and I'm about 1/3 the way through.

That said, yesterday it was still showing null. I threw in Caldari BS for several hours...I'm still training that Caldari BS (15 minutes left) and the Amarr Industrial shows (11d 6h); so I don't think there was any burn on Amarr Industrial between last night showing null and today...which leads me to think the API was sending out a null value.

On Tue, Dec 10, 2013 at 12:29 PM, Bleyddyn notifications@github.com wrote:

There haven't been any releases recently. It could be that the data returned by the API is now correct. I don't know what causes the problem but it could be that you got far enough into training the skill that it's now returning the right data.

— Reply to this email directly or view it on GitHubhttps://github.com/sixones/vitality/issues/27#issuecomment-30248855 .

Ben Wilson "A belief, no matter how sincere, if not reflected in reality isn’t a belief; it’s a delusion."

Merovex commented 10 years ago

Just cruising through the source code on Github, I'm not seeing a lot of exception trapping that feeds to the user. Would that help?

On Tue, Dec 10, 2013 at 12:59 PM, Ben Wilson dausha@gmail.com wrote:

Interesting that you came to the same likely conclusion...that the API finally returned a value that Vitality could process. I'm not familiar enough with the language or its layout to try to figure out where it's happening. I would assume that Vitality is freaking out and defaulting to zero for remaining Skill Points. Could it be based on the size of a variable (int v. large int)? The skill itself is 842K above Level VI and I'm about 1/3 the way through.

That said, yesterday it was still showing null. I threw in Caldari BS for several hours...I'm still training that Caldari BS (15 minutes left) and the Amarr Industrial shows (11d 6h); so I don't think there was any burn on Amarr Industrial between last night showing null and today...which leads me to think the API was sending out a null value.

On Tue, Dec 10, 2013 at 12:29 PM, Bleyddyn notifications@github.comwrote:

There haven't been any releases recently. It could be that the data returned by the API is now correct. I don't know what causes the problem but it could be that you got far enough into training the skill that it's now returning the right data.

— Reply to this email directly or view it on GitHubhttps://github.com/sixones/vitality/issues/27#issuecomment-30248855 .

Ben Wilson "A belief, no matter how sincere, if not reflected in reality isn’t a belief; it’s a delusion."

Ben Wilson "A belief, no matter how sincere, if not reflected in reality isn’t a belief; it’s a delusion."

Bleyddyn commented 10 years ago

I think this is a duplicate of issue #28 which I think is fixed. Marking as closed, until we get more info.