search

sixteenbit / device-mockups

No longer mirroring this repo with .org
http://wordpress.org/plugins/device-mockups/
28 stars 8 forks source link

Add smart TV's as device options #14

Open wpperform opened 9 years ago

wpperform commented 9 years ago

First, great plugin. Thanks for producing it.

I realize that your using a similar set of devices to those supported here: https://github.com/pixelsign/html5-device-mockups

But it would be great to add a smart TV (preferably brand-less) as a device option. For media (eg, video) focused sites, this would help to illustrate the point that the network isn't limited to traditional computing devices.

justin-peacock commented 9 years ago

Hey @wpperform

I'm glad you're finding it useful. You're right, Pixelsign was the initial build I got permission to use to build the shortcodes. Device Mockups has turned into a little bit more than that since then.

I plan to add more to DM but one thing I'm worried about is bloating the plugin. I want to avoid having every type of device imaginable and end up having 1GB of images.

That being said... I'm thinking about building add-ons to the plugin to where I could have an extension that would have all your smart TV's.

I'll put smart TV's on the to do list.

wpperform commented 9 years ago

Thanks for the very fast reply.

In ver 1.3.1, the img folder is about 5.3 Mb, so you've got a bit of breathing room before getting close to 1 Gb :) I agree with your notion not to add every device; I think the top 3-5 devices by market share is great coverage. Outside of smart TV's (and I'd be thrilled with a single generic smart TV), you've got great device coverage already.

Here's another thought to connect with your desire to limit the size of images on disk: how about providing a single default image so that if a user deletes the image associated with a device type, things will still function? Then, you could provide all the images you choose to provide and let users delete the ones they don't want taking up disk space. The default image + a few lines of instruction to users might be easier than building an extension.

Looking forward to continued improvements.

jphorn commented 8 years ago

I would love the idea of add-ons/device packs you could install at your own request. For our website I only need Apple devices (please include Apple Watch 42"!) and not any of the other devices. If I could only enable the (downloadable) device pack "Apple" that would make me very happy.

justin-peacock commented 8 years ago

Hey Guys,

It's definitely something I want to add to DM but I've been overloaded with projects lately. Hoping I can spend more time on updates after November.

JP