search

sixteenbit / device-mockups

No longer mirroring this repo with .org
http://wordpress.org/plugins/device-mockups/
28 stars 8 forks source link

Fix Plugin URL Path and Remove Custom Plugin URL. #15

Closed irazasyed closed 10 years ago

irazasyed commented 10 years ago

Current Method to Load Flexslider Fails for Custom Plugin Directory Setups. This uses standard method to load the JS correctly from Plugin's Directory.

We have custom path for wp-content and because this plugin uses a custom solution to build the URL, It ends up generating wrong path, hence it fails to load flexslider.

This patch fixes it.

justin-peacock commented 10 years ago

I'll test and push this tomorrow.

Thank you

On Oct 24, 2014, at 8:23 PM, Syed I.R notifications@github.com wrote:

Current Method to Load Flexslider Fails for Custom Plugin Directory Setups. This uses standard method to load the JS correctly from Plugin's Directory.

We have custom path for wp-content and because this plugin uses a custom solution to build the URL, It ends up generating wrong path, hence it fails to load flexslider.

This patch fixes it.

You can merge this Pull Request by running

git pull https://github.com/irazasyed/device-mockups patch-1 Or view, comment on, or merge it at:

https://github.com/mrdink/device-mockups/pull/15

Commit Summary

Fix Plugin URL Path and Remove Custom Plugin URL. File Changes

M device-mockups.php (9) Patch Links:

https://github.com/mrdink/device-mockups/pull/15.patch https://github.com/mrdink/device-mockups/pull/15.diff — Reply to this email directly or view it on GitHub.

irazasyed commented 10 years ago

Great :+1: