Shadow Lines on DH water

wmac302 commented 3 months ago

What happened?

On the latest dev branch the distant shadows on the water are really choppy. 2024-04-06_10 43 22 2024-04-06_10 43 28 2024-04-06_10 43 43

Minecraft Version

1.20.1

Which shader mod are you using?

Iris

Shader mod version

iris-mc1.20.1-1.7-alpha.1-185a9812

Shader settings

#Sat Apr 06 10:42:42 PDT 2024
AIR_FOG_RAYLEIGH_DENSITY=0.0001
COLORED_LIGHTS=true
AIR_FOG_MIE_DENSITY_MORNING=0.0001
AUTO_EXPOSURE=AUTO_EXPOSURE_HISTOGRAM
HANDHELD_LIGHTING=true
NORMAL_MAPPING=true
SH_SKYLIGHT=true
BLOOM_INTENSITY=1.75
SNELLS_WINDOW=true
ENTITY_SHADOWS=false
BLOOMY_FOG_INTENSITY=2.0
INFO=3
WATER_CAUSTICS=true
AIR_FOG_COLORED_LIGHT_SHAFTS=true
CLOUD_SHADOWS_INTENSITY=0.90
WATER_FOAM=true
SPECULAR_MAPPING=true
PURKINJE_SHIFT=false
PIXELATED_SHADOWS_RESOLUTION=4
VANILLA_MOON=false

Relevant log output

No response

sixthsurge commented 3 months ago

precision issue I think, I combined the MC/DH depth buffers into one with a custom projection matrix that has the near plane of the normal depth buffer and a very far far plane. it will be better in the next commit because I made the far plane for the combined depth buffer be based on the DH render distance

wmac302 commented 3 months ago

I closed this pre-maturely. I'm sure you're still aware of it but just wanted to keep it on your radar now that you're up and running on modrinth :). Still the same choppy distant water shadows on latest commit.

sixthsurge / photon