sixthsurge / photon

A gameplay-focused shader pack for Minecraft
MIT License
912 stars 190 forks source link

OVERLAYED Parallax Occlusion Mapping #194

Closed Patomosm closed 2 days ago

Patomosm commented 1 week ago

What happened?

(Minecraft 1.21 version) Stretched pixels at the opposite edges of overlayed textures (cobblestone's in the pictures).

Base Profile Screenshot 2024 07 04 - 15 35 53 21

Minecraft Version

Other

Which shader mod are you using?

Iris

Shader mod version

1.7.1

Shader settings

#Thu Jul 04 15:37:18 CEST 2024
AIR_FOG_COLORED_LIGHT_SHAFTS=true
AIR_FOG_MIE_DENSITY_BLUE_HOUR=0.0030
AIR_FOG_MIE_DENSITY_EVENING=0.0060
AIR_FOG_MIE_DENSITY_MIDNIGHT=0.0060
AIR_FOG_MIE_DENSITY_MORNING=0.0080
AIR_FOG_MIE_DENSITY_NOON=0.0011
AIR_FOG_MIE_DENSITY_RAIN=0.040
AIR_FOG_RAYLEIGH_DENSITY=0.0010
AIR_FOG_RAYLEIGH_DENSITY_JUNGLE=0.0023
AIR_FOG_RAYLEIGH_DENSITY_RAIN=0.0015
AIR_FOG_RAYLEIGH_DENSITY_SNOWY=0.0020
AIR_FOG_RAYLEIGH_DENSITY_SWAMP=0.0024
AIR_FOG_RAYLEIGH_DENSITY_TAIGA=0.0016
AUTO_EXPOSURE=AUTO_EXPOSURE_HISTOGRAM
AUTO_EXPOSURE_MAX=0.2
AUTO_EXPOSURE_MIN=-0.2
BLOCK_ENTITY_SHADOWS=true
BLOOM_INTENSITY=2.00
BOUNCED_LIGHT_I=2.00
CAVE_LIGHTING_I=0.33
CLOUD_SHADOWS_INTENSITY=0.67
COLORED_LIGHTS=true
COLORED_LIGHTS_VANILLA_LIGHTMAP_CONTRIBUTION=false
CUSTOM_SKY=true
DIRECTIONAL_LIGHTMAPS_INTENSITY=0.50
EDGE_HIGHLIGHT_SCALE=128.0
EMISSION_STRENGTH=1.50
FXAA=false
GRADE_CONTRAST=1.20
GRADE_SATURATION=0.80
HANDHELD_LIGHTING=true
INFO=0
MOON_ANGULAR_RADIUS=1.5
MOON_I=0.50
NETHER_FOG_INTENSITY=1.50
NETHER_I=0.67
NETHER_S=0.67
POM_DEPTH=0.20
POM_SHADOW=true
RAIN_OPACITY=1.00
SHADING_STRENGTH=2.00
SH_SKYLIGHT=true
SPECULAR_MAPPING=true
SSR_INTERSECTION_STEPS_SMOOTH=12
SSR_RAY_COUNT=3
SSR_REFINEMENT_STEPS=3
SSR_ROUGHNESS_THRESHOLD=1.0
STARS_COVERAGE=1.00
SUN_ANGULAR_RADIUS=1.6
SUN_EB=0.50
SUN_EG=0.67
SUN_ER=0.75
SUN_MB=0.67
SUN_MG=0.75
SUN_MR=0.80
SUN_NB=0.90
SUN_NR=0.90
TAAU=true
VIGNETTE=false
VOXEL_VOLUME_SIZE=64
WATER_CAUSTICS=true
WATER_FOAM=true
WATER_WAVE_PERSISTENCE=0.50
WATER_WAVE_SPEED_STILL=0.50
WATER_WAVE_STRENGTH=0.50
WAVING_PLANTS=false

Relevant log output

No response

GitCodMaster commented 1 week ago

When you enable Paralax occulusion mapping, then you should have a paralax Recource pack too that supports labPBR. like this: https://www.planetminecraft.com/texture-pack/ultimacraft-pbr-labpbr/ or this: https://www.curseforge.com/minecraft/texture-packs/vanilla-pbr/files/4426215

Patomosm commented 1 week ago

Yes, it is. My resource pack is labPBR capable.

Base Profile Screenshot 2024 06 18 - 12 19 15 10

Base Profile Screenshot 2024 06 18 - 14 25 01 65

Patomosm commented 1 week ago

In not only an underwater issue...

https://github.com/sixthsurge/photon/assets/133518090/a6be53c2-22e1-458a-8930-84a1d9e38077

Patomosm commented 2 days ago

Catch it! ... the same issue is present in Complementary when you enable "POM on cut surfaces". This option is not present in Photon to switch off. Ta-daaa!